Open
Conversation
luka-nextcloud
added
3. to review
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
blizzz
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Productivity team
Signed-off-by: Luka Trovic <luka@nextcloud.com>
luka-nextcloud
force-pushed
the
update-loading-table-shares
branch
from
ca1f25a to
fac3f80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update access control for viewing table shares and improves the user interface logic to ensure only authorized users can load share information.
The
indexmethod inShareController.phpnow requiresMANAGEpermission instead ofREADto access table shares, ensuring only users with management rights can view share information.The
indexViewmethod inShareController.phpnow requiresMANAGEpermission instead ofREADto access view shares, ensuring only users with management rights can view share information.In
Dashboard.vue, theloadSharesmethod now checks if the user can manage the table before loading its shares, preventing unauthorized users from accessing share data.